Skip to content

Add the prompt-cursor-{colour,style} options (issue #4117)#4170

Closed
lexurco wants to merge 3 commits intotmux:masterfrom
lexurco:emulate-cursor-option
Closed

Add the prompt-cursor-{colour,style} options (issue #4117)#4170
lexurco wants to merge 3 commits intotmux:masterfrom
lexurco:emulate-cursor-option

Conversation

@lexurco
Copy link
Copy Markdown

@lexurco lexurco commented Oct 7, 2024

This implements the two options, as discussed in issue #4117:

  • prompt-cursor-colour cursor colour in prompt, cf. cursor-colour
  • prompt-cursor-style cursor style in prompt, cf. cursor-style

At the moment, upstream tmux hides "real" cursor when entering prompt, to instead emulate it. These options make the behaviour unnecessary, so that's been removed.

@nicm
Copy link
Copy Markdown
Member

nicm commented Oct 7, 2024

Thanks. Don't you also need to remove cursorgc and bit that draws the space as well?

@lexurco
Copy link
Copy Markdown
Author

lexurco commented Oct 7, 2024

Indeed. Should be fixed now. Thanks!

@nicm
Copy link
Copy Markdown
Member

nicm commented Oct 7, 2024

OK, I have applied to OpenBSD now with some trivial changes, will be in GitHub later.

Unfortunately a default cursor of black doesn't really work because the text is black and it doesn't reverse so the actual character under the cursor becomes invisible, so I made it cyan instead.

Thanks!

@nicm nicm closed this Oct 7, 2024
@lexurco lexurco deleted the emulate-cursor-option branch October 20, 2024 09:15
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants