Fix improper vsyslog detection and conditional compilation#574
Closed
lublog wants to merge 1 commit intotinyproxy:masterfrom
Closed
Fix improper vsyslog detection and conditional compilation#574lublog wants to merge 1 commit intotinyproxy:masterfrom
lublog wants to merge 1 commit intotinyproxy:masterfrom
Conversation
Contributor
|
good catch. since the unportable code trying to use it was unused anyway, i just went ahead and removed it instead. out of curiosity: is this PR and the issue text AI-generated? |
Author
|
I noticed this issue, but my English isn't very good. I was afraid my description might not be accurate enough, so I explained the problem to AI to help generate the proper expression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a build and behavior issue in
log.cwherevsyslog()is conditionally compiled using an incorrect macro:HAVE_VSYSLOG_H.Problem
The current code checks for
vsyslog()support using:However,
vsyslog.hdoes not exist in any standard C library. Sincevsyslog()is not part of the POSIX standard, it should be detected using Autoconf viaAC_CHECK_FUNCS, rather than relying on a non-existent header macro.Fix
In
configure.ac, modified the function checks from:to:
In
log.c, updated the conditional compilation to: