Omit the version number from headers and HTML responses#543
Merged
rofl0r merged 2 commits intotinyproxy:masterfrom Jun 20, 2024
jpmckinney:no-version-disclosure
Merged
Omit the version number from headers and HTML responses#543rofl0r merged 2 commits intotinyproxy:masterfrom jpmckinney:no-version-disclosure
rofl0r merged 2 commits intotinyproxy:masterfrom
jpmckinney:no-version-disclosure
Conversation
Contributor
that sounds like the best option, indeed. |
Contributor
Author
|
Cool, I made the commit :) |
Contributor
Author
|
Thanks @rofl0r - just curious what the release cadence is? |
Contributor
|
a click on the releases tab should answer your question. it's typically > 12 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #542
I haven't written C or Perl in over a decade, but I think I got it (assuming tests pass).
I don't know what effect this line has, so I left it:
tinyproxy/src/html-error.c
Line 277 in 72b93f6
Edit: Aha, I think this fills in the version variable in the HTML templates. I can delete the
{version}from the HTML templates and leave this variable (in case users want to customize the templates to add the version back) – or I can delete both (meaning users can't restore the variable), or I can not do anything (requiring users to edit templates to prevent disclosure of the version).