Barcelona | Oct-2025 | Angela Onyekwelu | Module-Legacy-Code | Sprint-1 |Fix bloom - #2
Open
theangelskies wants to merge 4 commits into
Open
Barcelona | Oct-2025 | Angela Onyekwelu | Module-Legacy-Code | Sprint-1 |Fix bloom#2theangelskies wants to merge 4 commits into
theangelskies wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Enforce 280-character bloom limit server-side
The 280-character bloom limit was only ever enforced in the browser, via the textarea's maxlength attribute and a JS counter. The /bloom endpoint itself accepted content of any length, so anything posted directly to the API bypassed the limit entirely — which is exactly how AS ended up with a 375-character bloom in the seed data, since populate.py talks to the API directly rather than through the UI.
This adds a real server-side check in send_bloom(), rejecting anything over 280 characters with a 400 and a clear message, the same pattern already used for the minimum password length in register(). AS's seed bloom in populate.py was trimmed to fit under the new limit so populate.py keeps working.
Verified against a live backend: a 280-char post succeeds, 281 is rejected, populate.py runs clean, and AS's profile no longer shows any bloom over the limit.
Questions
Ask any questions you have for your reviewer. You must remove this section if you have no questions.