Barcelona | Oct-2025 | Angela Onyekwelu | Module-Legacy-Code | Sprint-1 | Fix login - #1
Open
theangelskies wants to merge 1 commit into
Open
Barcelona | Oct-2025 | Angela Onyekwelu | Module-Legacy-Code | Sprint-1 | Fix login#1theangelskies wants to merge 1 commit into
theangelskies wants to merge 1 commit into
Conversation
…g and profile views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix login event listener to use 'submit' instead of 'click' in hashtag and profile views
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Fix login not working from profile/hashtag pages
Logging in from the profile or hashtag view silently failed (browser fell back to a native form POST → 501 from the dev server), because both views bound the login handler to a click on [data-action="proxy.php?url=https%3A%2F%2Fgithub.com%2Ftheangelskies%2FModule-Legacy-Code%2Fpull%2Flogin"], an element that doesn't exist in the login template. profile.mjs and hashtag.mjs now bind handleLogin to the form's submit event via [data-form='login'], matching home.mjs/bloom.mjs.
Questions
Ask any questions you have for your reviewer. You must remove this section if you have no questions.