Fix tf.ragged.constant shape inference for uniform outer dimensions#115237
Open
Khalodddd wants to merge 6 commits intotensorflow:masterfrom
Open
Fix tf.ragged.constant shape inference for uniform outer dimensions#115237Khalodddd wants to merge 6 commits intotensorflow:masterfrom
tf.ragged.constant shape inference for uniform outer dimensions#115237Khalodddd wants to merge 6 commits intotensorflow:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@google-cla recheck |
f157a7a to
06a1067
Compare
tf.ragged.constant shape inference for uniform outer dimensions #40159
|
following up |
Author
|
@google-ml-butler Could someone please re-run the PyLint check? I've pushed a fix for the line-too-long errors. Thank you! |
tf.ragged.constant shape inference for uniform outer dimensions #40159tf.ragged.constant shape inference for uniform outer dimensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes two bugs in
tf.ragged.constant:(3,0)instead of(3, None)) – discovered while fixing bug 2.The Problem
tf.ragged.constant([[], [], []])returned shape(3,0)– a dense dimension of size 0, which is wrong because the inner dimension should be ragged (None). This bug was found during testing of the fix for bug 2.tf.ragged.constant([[[1],[2,3],[4]],[[5,6],[],[7]]])returned shape(2, None, None)instead of the expected(2, 3, None). Uniform outer dimensions (2 and 3) were lost.Key Changes
ragged_factory_ops.py:_default_inner_shape_for_pylist, addedif not flat_values: return ()to prevent a zero‑length dense inner shape for empty lists (fixes bug 1)._constant_value, added static shape inference that:inner_shapedimensions asNone, preserving existing behavior for dense tensors (fixes bug 2).ragged_const_op_test.py:testUniformOuterDimensionDetectionwith five cases covering 3D, 4D, empty inner lists, all‑ragged, and explicitragged_rank/inner_shape.Verification
Below is a screenshot of the command line after running the test file:
python ragged_const_op_test.py
Results Summary
tf.ragged.constant([[], [], []])→(3, None)✅tf.ragged.constant([[[1],[2,3],[4]],[[5,6],[],[7]]])→(2, 3, None)✅[[1,2,3],[4,5,6],[7,8,9]]→(3, None)unchanged).