PR for taskphp/task#6#1
Merged
mbfisher merged 5 commits intotaskphp:masterfrom May 30, 2014
laurisb:patch-1
Merged
Conversation
Contributor
|
Great, thanks! Looking into it now. Travis build is failing, I suspect because the tests haven't been updated. M |
Contributor
There was a problem hiding this comment.
This is a syntax error. Can just be:
if (!($project instanceof Project)) {
Contributor
Author
|
Fixed. |
Contributor
|
Yup, tests are failing. Can you update them and add coverage for the new functionality please? M |
Contributor
Author
|
Done. |
Contributor
|
Brilliant, thanks! I've PRd your PR with a couple of tweaks, including removing those extra project checks that you've highlighted. M |
Remove superfluous project checks
mbfisher
added a commit
that referenced
this pull request
May 30, 2014
Merge pull request #1 from laurisb/patch-1
Contributor
|
Thanks again! M |
mbfisher
added a commit
that referenced
this pull request
May 30, 2014
Merge pull request #1 from laurisb/patch-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiple options for Taskfile name