Minimal set of changes for returning failure to find non-zero pivot - #1990
Open
bjodah wants to merge 13 commits into
Open
Minimal set of changes for returning failure to find non-zero pivot#1990bjodah wants to merge 13 commits into
bjodah wants to merge 13 commits into
Conversation
…/github.com/bjodah/symengine into return-int-fraction_free_gauss_jordan_solve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal set of changes to hopefully fix gh-1989.
Do you think the approach is sound? Should we merge this subset of changes. Or should the PR include changes to all decomposition methods perhaps?