-
-
Notifications
You must be signed in to change notification settings - Fork 25
Map Docs #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Map Docs #70
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Awesome. |
|
As I'm writing this section, @gka, I find it weird that the current available transforms are inside a "Map" category. As per I would expect a Map transformer to receive a callback function that transforms the data in some way. For example, taking all Athlete names and converting them to a smaller format: "Michael Phelps" → "M. Phelps" This is a small example but I think it gets the point across of what I'm trying to say. Maybe the current "Map" section could be called "Summarize", a series of transformations to summarize the data, in which we can now include the rest of the available methods, like sum, min, max, and so on. Maybe I'm understanding it wrong, though! Would love if you could shed some light on this topic! |
I'd expect a I'd expect a Cumsum, rank and quantile transform a list of values to another list of values, so I think they're more appropriately described as However, I would generally expect a |
I guess this is the core issue: it's a cumsum is a Map because it receives an array and outputs an array of the same size, but output is dependent on all elements GlobalMap, or something along those lines could work. I do agree, though, to stick to Observable's API naming. In fact, I was trying to stick with d3's! |
|
Hi, apologies for my long silence here. Thanks a lot for taking on the map docs!
In SveltePlot this would just be a channel accessor. E.g. to lowercase athlete names you wouldn't use any transform but just a function accessor: I don't think we need to add a transform for these cases.
I don't think map and summarize would be the same. Map always returns a list of values (just like the (Also for actual summarizing you can use the group and bin transforms)
Well, the actual difference between using an accessor function and using a map transform is that the latter does give you access to the entire array while the former only operates on a single datum. This is the reason why you can use the map transform to normalize data. Under the hood, the normalize transform is using the map transform. But this discussion shows that these are useful things to clear up in the documentation of the map transform! As for the examples included in the PR: I like the cumsum example, that's very clear, but I think the other examples are a bit too complicated. For instance, we could add an example using the
|

fixes #10