Skip to content

Revert fine-grained host paths for compliance mounts - #3850

Merged
vikin91 merged 3 commits into
masterfrom
rc-revert-minimal-host-mounts
Nov 18, 2022
Merged

Revert fine-grained host paths for compliance mounts#3850
vikin91 merged 3 commits into
masterfrom
rc-revert-minimal-host-mounts

Conversation

@robbycochran

@robbycochran robbycochran commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Description

An issue was found in https://issues.redhat.com/browse/ROX-13580 that caused the new compliance mounts to fail due missing /srv on COS nodes.

Revert "Fix collector volumeMounts #2479"
Revert "Use fine-grained host paths for compliance mounts #2479"

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@robbycochran robbycochran added this to the 3.73.0-rc.1 milestone Nov 18, 2022
@ghost

ghost commented Nov 18, 2022

Copy link
Copy Markdown

Images are ready for the commit at c60a902.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-24-gc60a9021c5.

@robbycochran robbycochran added the pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted label Nov 18, 2022
@robbycochran

Copy link
Copy Markdown
Contributor Author

/test gke-version-compatibility-tests

@janisz

janisz commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

/retest

@vikin91
vikin91 merged commit 772ffd9 into master Nov 18, 2022
@vikin91
vikin91 deleted the rc-revert-minimal-host-mounts branch November 18, 2022 11:39
@github-actions

Copy link
Copy Markdown
Contributor

Please merge the changes to branch release-3.73.

@github-actions

Copy link
Copy Markdown
Contributor

Please merge the changes to branch release-3.73.

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Please merge the changes to branch release-3.73.

@janisz janisz removed this from the 3.73.0-rc.1 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants