ROX-13540: Allow Sensor Component `NodeScanHandler` to start max. once - #3800

Merged

vikin91 merged 38 commits into

pr/ROX-12835-followup-1

Nov 29, 2022

Commits on Nov 28, 2022

Fix: Ensure that consecutive calls to nodeScanHandlerImpl.Start don't panic
vikin91
committed
ad9cf66
Optimize nodeScanHandlerImpl.sendScan
vikin91
committed
c441c41
Remove stoppedC, fix race condition in test
vikin91
committed
41dd60f
Minor: Tune a comment and reduce a line
vikin91
committed
4df0e64
Make the nodeScanHandlerImpl restartable
vikin91
committed
70b80bb
Rename mutex var
vikin91
committed
da01dfe
Rename var runFinishedC to stoppedC
vikin91
committed
053b710
Undo restartability: allow the component to Start() once
vikin91
committed
375a03e
Extend comment for the test where producer stops the component after the first message
vikin91
committed
c5052a7
Change error message when starting NodeScanHandler for the N>1 time
vikin91
committed
17932b4
Make deferred statement evaluate properly
vikin91
committed
32ba377
Do not initialize toCentral chan twice
vikin91
committed
7e85378
Correct comment
vikin91
committed
943deee
Address race in TestHandlerStoppedError by accepting both values
vikin91
committed
889e083
Delete SetupTest and make sure that the Suite implements the interface
vikin91
committed
142289d
Add waiting for Stopped() in TestStopHandler
vikin91
committed
b8a647d
Rephrase comment in TestStopHandler
vikin91
committed
38c94fe
Add more assertions to TestHandlerRegularRoutine
vikin91
committed
86dae6e
Ensure all test cases do h.Stopped().Wait()
vikin91
committed
c008157
WIP: Rework tests
vikin91
committed
283a43e
Reword comment
vikin91
committed
98a2509
Fix race in TestStopHandler between handler Stop and receiver receiving first message
vikin91
committed
d9fcadc
Stop(nil) and skip stopAll in TestHandlerRegularRoutine
vikin91
committed
83f8613
Skip stopAll in TestHandlerStoppedError
vikin91
committed
706d1aa
Cleanup generateTestInputNoClose
vikin91
committed
cc6fd29
Improve TestRestartHandler
vikin91
committed
ae283da
Improve TestDoubleStartHandler and TestDoubleStopHandler
vikin91
committed
d948528
Temporarily revert "Fix race in TestStopHandler between handler Stop and receiver receiving first message"
vikin91
committed
13befb8
Remove the test context
vikin91
committed
dc50b12
Do not defer assertNoGoroutineLeaks
vikin91
committed
a4f7112
Correct stopAll code in TestStopHandler
vikin91
committed
8369b91
Remove redundant waiting in TestRestartHandler
vikin91
committed
ad836f8
Remove stopAll and fix race in TestStopHandler
vikin91
committed
06bc997
Fix hidden race in TestMultipleStartHandler
vikin91
committed
a4c6c54
Remove redundant TestRestartHandler
vikin91
committed
e22e35b
Remove assertions NotPanics
vikin91
committed
ed00521
Add coverage with test TestInputChannelClosed
vikin91
committed
e385c20
Fine details: comments and order of cleanup
vikin91
committed
5246c62