Skip to content

🚨 G303 gosec rule enabled - #3560

Merged
janisz merged 2 commits into
stackrox:masterfrom
bgalek:G303
Oct 26, 2022
Merged

🚨 G303 gosec rule enabled#3560
janisz merged 2 commits into
stackrox:masterfrom
bgalek:G303

Conversation

@bgalek

@bgalek bgalek commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Description

G303 check enabled in gosec config

@openshift-ci

openshift-ci Bot commented Oct 25, 2022

Copy link
Copy Markdown

Hi @bgalek. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions Bot added the external-contributor To put on issues and PRs from external contributors label Oct 25, 2022
@janisz
janisz self-requested a review October 26, 2022 16:36
@janisz

janisz commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

/ok-to-test

@janisz janisz mentioned this pull request Oct 26, 2022
Open
34 tasks
@openshift-ci

openshift-ci Bot commented Oct 26, 2022 •
edited
Loading

Copy link
Copy Markdown

@bgalek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-qa-e2e-tests 1868409 link false /test gke-postgres-qa-e2e-tests
ci/prow/gke-nongroovy-e2e-tests 1868409 link false /test gke-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests 1868409 link false /test gke-qa-e2e-tests
ci/prow/push-images 1868409 link true /test push-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
janisz enabled auto-merge (squash) October 26, 2022 16:54
@janisz
janisz disabled auto-merge October 26, 2022 16:54
@janisz
janisz enabled auto-merge (squash) October 26, 2022 16:54
@ghost

ghost commented Oct 26, 2022

Copy link
Copy Markdown

Images are ready for the commit at f7336de.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-417-gf7336defb6.

@janisz
janisz merged commit 854411b into stackrox:master Oct 26, 2022
ivan-degtiarenko pushed a commit that referenced this pull request Nov 5, 2022
@bgalek @janisz @ivan-degtiarenko
G303 gosec rule enabled (#3560)
2e0403b 
Co-authored-by: Tomasz Janiszewski <tomek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

external-contributor To put on issues and PRs from external contributors ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgalek @janisz