ROX-33963: Remove Orchestrator Components code from NetGraph#20108
ROX-33963: Remove Orchestrator Components code from NetGraph#20108dvail wants to merge 1 commit intodv/ROX-33962-remove-orchestrator-from-searchfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
| // for openshift filtering toggle | ||
| if ( | ||
| !includeOrchestratorComponents && | ||
| localStorage.getItem(ORCHESTRATOR_COMPONENTS_KEY) !== 'true' | ||
| ) { | ||
| urlParams.scope = { | ||
| query: 'Orchestrator Component:false', | ||
| }; | ||
| } |
There was a problem hiding this comment.
These blocked never execute, as ALWAYS_SHOW_ORCHESTRATOR_COMPONENTS is always true, which causes an immediate short circuit.
🚀 Build Images ReadyImages are ready for commit 541cbc6. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-691-g541cbc6335 |
1 similar comment
🚀 Build Images ReadyImages are ready for commit 541cbc6. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-691-g541cbc6335 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-33962-remove-orchestrator-from-search #20108 +/- ##
================================================================================
- Coverage 49.69% 49.69% -0.01%
================================================================================
Files 2766 2766
Lines 209184 209175 -9
================================================================================
- Hits 103959 103948 -11
Misses 97538 97538
- Partials 7687 7689 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
As titled - this is effectively a no-op as the Network Graph was hardcoded to always include Orchestrator Components, but now the dead code is removed.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
See requests do not include
Orchestrator Componentsfilter:See that the option for "Platform Components" is available in the search filter:
