ROX:34136, ROX:34137: Fix tagless images' name and link display under CVE and Deployment pages#19992
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19992 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 2766 2766
Lines 209352 209356 +4
=======================================
+ Hits 104051 104055 +4
Misses 97611 97611
Partials 7690 7690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 Build Images ReadyImages are ready for commit 8e1c01a. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-706-g8e1c01adf3 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes extend GraphQL Image schema and related fragments to include a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… images Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cd9d549 to
8e1c01a
Compare
|
This change is part of the following stack: Change managed by git-spice. |
Description
When
FlattenImageDatais enabled, the image id field becomes a UUID instead of a SHA digest. Several views in Workload CVEs used the id field as a fallback display value for tagless images (viaImageNameLinkandgetImageBaseNameDisplay), causing UUIDs to appear instead of digests.This PR adds a digest field to the Image GraphQL type and passes it to the UI so that tagless images always display the SHA digest regardless of the FlattenImageData flag.
Changes
Backend — central/graphql/resolvers/images.go
UI — ImageResourceTable.tsx (Deployment single page → Resources tab)
UI — table.utils.ts (Workload CVE single page)
ImageNameLink renders an image name.
The ImageNameLink component (ImageNameLink.tsx:30) already prefers digest over id when present (const imageShaForDisplay = digest || id), so the fix is purely about fetching and passing the
new field.
User-facing documentation
Testing and quality
Automated testing
How I validated my change