ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests by janisz · Pull Request #19306 · stackrox/stackrox

janisz · 2026-03-05T11:30:00Z

Description

Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 and #17216.

Changes:

scripts/ci/lib.sh: Add *compatibility-tests case to prefetcher start, await, and image list population functions
tests/e2e/run-compatibility.sh: Call prefetcher before deployment setup

The existing tests/images-to-prefetch.txt already contains the nginx image used by compatibility tests (quay.io/rhacs-eng/qa-multi-arch:nginx-1-17-1 in tests/tls_challenge_test.go).

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

change me!

Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 for sensor integration tests. Changes: - scripts/ci/lib.sh: Add *compatibility-tests case to prefetcher start, await, and image list population functions - tests/e2e/run-compatibility.sh: Call prefetcher before deployment setup The existing tests/images-to-prefetch.txt already contains the nginx image used by compatibility tests (quay.io/rhacs-eng/qa-multi-arch:nginx-1-17-1 in tests/tls_challenge_test.go). User request: look at this PR #18867 we need to add prefetcher to gke-nongroovy-compatibility-tests Code changes developed with AI assistance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

janisz · 2026-03-05T11:30:21Z

/test gke-compatibility

janisz · 2026-03-05T11:30:46Z

/test gke-nongroovy-compatibility-tests

janisz · 2026-03-05T11:32:02Z

/test gke-nongroovy-compatibility-tests

Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 for sensor integration tests. Changes: - scripts/ci/lib.sh: Add *compatibility-tests case to prefetcher start, await, and image list population functions - tests/e2e/run-compatibility.sh: Call prefetcher before deployment setup - tests/yamls/multi-container-pod.yaml: Change imagePullPolicy from IfNotPresent to Never to use prefetched images The existing tests/images-to-prefetch.txt already contains the nginx and ubuntu images used by compatibility tests. The YAML file change is necessary because pods created directly from YAML don't go through the createDeploymentViaAPI code that respects IMAGE_PULL_POLICY_FOR_QUAY_IO. User request: look at this PR #18867 we need to add prefetcher to gke-nongroovy-compatibility-tests Code changes developed with AI assistance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

janisz · 2026-03-05T11:43:18Z

/test gke-nongroovy-compatibility-tests

rhacs-bot · 2026-03-05T11:48:06Z

Images are ready for the commit at ac9bd70.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-248-gac9bd7006e.

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>

janisz · 2026-03-05T11:52:23Z

/test gke-nongroovy-compatibility-tests

codecov · 2026-03-05T12:35:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.62%. Comparing base (092168e) to head (ac9bd70).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19306      +/-   ##
==========================================
- Coverage   49.62%   49.62%   -0.01%     
==========================================
  Files        2680     2680              
  Lines      202231   202231              
==========================================
- Hits       100366   100363       -3     
- Misses      94379    94383       +4     
+ Partials     7486     7485       -1

Flag	Coverage Δ
go-unit-tests	`49.62% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

openshift-ci · 2026-03-05T14:24:11Z

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/gke-scanner-v4-install-tests	`ac9bd70`	link	false	`/test gke-scanner-v4-install-tests`
ci/prow/ocp-4-20-operator-e2e-tests	`ac9bd70`	link	false	`/test ocp-4-20-operator-e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

janisz · 2026-03-05T14:25:39Z

/retest

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

rhacs-bot · 2026-04-24T09:38:33Z

The backport to release-4.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-4.10 release-4.10
# Navigate to the new working tree
cd .worktrees/backport-release-4.10
# Create a new branch
git switch --create backport-19306-to-release-4.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 365c5c84ba00d6e52bb67bc9052f767f4403299c
# Push it to GitHub
git push --set-upstream origin backport-19306-to-release-4.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-4.10

Then, create a pull request where the base branch is release-4.10 and the compare/head branch is backport-19306-to-release-4.10.

…y tests The previous commit added prefetcher start/await cases for *compatibility-tests jobs but missed adding the corresponding cases in populate_prefetcher_image_list(), causing it to call die() with "unsupported image prefetcher target" and exit 1 before the GKE cluster was even provisioned. Add nongroovy-compatibility and compatibility cases, pointing to the same images-to-prefetch.txt files used by the analogous e2e test jobs. Matches the fix in master (PR #19306). Partially generated with AI assistance.

janisz commented Mar 5, 2026

View reviewed changes

Comment thread tests/e2e/run-compatibility.sh Outdated

Apply suggestion from @janisz

173b162

janisz changed the title ~~Add image prefetcher to gke-nongroovy-compatibility-tests~~ ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests Mar 5, 2026

fix

ac9bd70

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>

janisz requested a review from mtodor March 5, 2026 14:26

mtodor approved these changes Mar 5, 2026

View reviewed changes

janisz merged commit 365c5c8 into master Mar 5, 2026
99 of 104 checks passed

janisz deleted the fix_compatibility_tests branch March 5, 2026 14:49

ksurabhi91 pushed a commit that referenced this pull request Mar 12, 2026

ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests (#19306)

7fe4cf4

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

guzalv added the backport release-4.10 label Apr 24, 2026

guzalv mentioned this pull request Apr 24, 2026

ci: prefetch images for compatibility tests in release-4.10 #20211

Merged

8 tasks

Navigation Menu

Uh oh!

ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests - #19306

ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests#19306
janisz merged 4 commits into
masterfrom
fix_compatibility_tests

janisz commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

rhacs-bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

codecov Bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

Uh oh!

rhacs-bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

janisz commented Mar 5, 2026

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

rhacs-bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

codecov Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci Bot commented Mar 5, 2026

Uh oh!

janisz commented Mar 5, 2026

Uh oh!

Uh oh!

rhacs-bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rhacs-bot commented Mar 5, 2026 •

edited

Loading

codecov Bot commented Mar 5, 2026 •

edited

Loading