ROX-33255: Apply TLS settings to config-controller and internal server - #19187
Merged
Conversation
vladbologa
force-pushed
the
vb/tls-settings-servers
branch
from
February 25, 2026 14:11
7dc4653 to
c15d432
Compare
kylape
approved these changes
Feb 25, 2026
kylape
left a comment
Contributor
There was a problem hiding this comment.
By "fixes" you mean that these go servers will now utilize the centralized TLS config, right?
Contributor
|
Images are ready for the commit at c15d432. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19187 +/- ##
==========================================
- Coverage 49.55% 49.55% -0.01%
==========================================
Files 2675 2675
Lines 201820 201820
==========================================
- Hits 100015 100008 -7
- Misses 94345 94350 +5
- Partials 7460 7462 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up on #19110, this PR fixes remaining servers (config-controller metrics, central internal server) that do not use the centralized TLS profile.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI should be sufficient