Improve e2e testcase for RHCOS - #1045
Conversation
We claim that the tzdata package has lower chance of finding vulnerabilities in it than grep.
|
Images are ready for the commit at 9176389. To use the images, use the tag |
|
The modified test case passed in CI. All failures in the recent CI run are unrelated. |
|
/retest |
|
I think another option is to add some flag to the test to indicate if you want to bother looking at the vuln data or not (or even just check for specific vulns). We have this precedent set in other parts of the e2e tests (see testcase_test.go) |
|
@vikin91: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks Ross! I see that I would need to introduce such flag like I will give it a try a separate PR to keep this change small. |
This is a follow-up to #1004.
In the test case, we need a package that has high probability of being free from vulnerabilities because we assert on it to be recognized by scanner and have exactly 0 vulnerabilities.
In this PR, I replace the previously used
grepbytzdataguesstimating that the chance of finding a vulnerability in the latter is lower than in the former.Tested
On CI and locally with:
make image deploy-localgo test -tags e2e -timeout=10s -count=1 -v -run ^TestGRPCGetRHCOSNodeVulnerabilities$ github.com/stackrox/scanner/e2etests