Skip to content

1.1.1 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcj merged 10 commits into from
Jul 19, 2021
Merged

1.1.1 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a72bd98
Add shutdown command
pcj Oct 16, 2020
50427a2
Display server tool path
pcj Oct 16, 2020
1516857
Merge branch 'server-shutdown-command' of https://github.com/stackb/b…
pcj Oct 16, 2020
37ccd8b
Merge branch 'master' of https://github.com/stackb/bazel-stack-vscode
pcj Oct 20, 2020
5857ac7
Merge branch 'master' of https://github.com/stackb/bazel-stack-vscode
pcj Oct 26, 2020
7bfbcbf
Merge branch 'master' of https://github.com/stackb/bazel-stack-vscode
pcj Oct 28, 2020
45d75a1
Merge branch 'master' of https://github.com/stackb/bazel-stack-vscode
pcj Nov 20, 2020
b822b56
Merge branch 'master' of https://github.com/stackb/bazel-stack-vscode
pcj Jul 19, 2021
025cd4f
Skip quote escape on windows
pcj Jul 19, 2021
6dc4751
Cleanup commented code
Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "bazel-stack-vscode",
"displayName": "bazel-stack-vscode",
"description": "Bazel Support for Visual Studio Code",
"version": "1.1.0",
"version": "1.1.1",
"publisher": "StackBuild",
"license": "Apache-2.0",
"icon": "stackb-full.png",
Expand All @@ -26,6 +26,8 @@
"onUri",
"onCommand:bsv.openExtensionSetting",
"onCommand:workbench.view.extension.bazel-explorer",
"onView:bsv.workspace",
"onView:bazel-explorer",
"onLanguage:bazel",
"onLanguage:bazelrc",
"onLanguage:starlark"
Expand Down Expand Up @@ -660,4 +662,4 @@
"tabWidth": 2,
"arrowParens": "avoid"
}
}
}
9 changes: 8 additions & 1 deletion src/bezel/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as os from 'os';
import * as vscode from 'vscode';
import { ComponentConfiguration } from './configuration';
import { quote } from 'shell-quote';
Expand Down Expand Up @@ -291,7 +292,13 @@ export abstract class LaunchableComponent<
const terminal = vscode.window.createTerminal(this.terminalName);
this.terminal = terminal;

terminal.sendText(quote(args), true);
let command = '';
if (os.platform() === 'win32') {
command = args.join(' ');
} else {
command = quote(args);
}
terminal.sendText(command, true);
terminal.show();

this.setStatus(Status.LAUNCHING);
Expand Down