Skip to content

chore: Remove obsolete build scripts#3518

Merged
justinclift merged 3 commits into
masterfrom
remove-scripts
Dec 11, 2023
Merged

chore: Remove obsolete build scripts#3518
justinclift merged 3 commits into
masterfrom
remove-scripts

Conversation

@lucydodo

Copy link
Copy Markdown
Member

We recently finished moving our build system to GitHub Actions, so I've been removing obsolete scripts.

We recently finished moving our build system to GitHub Actions,
so I've been removing obsolete scripts.
@lucydodo lucydodo self-assigned this Dec 10, 2023
@justinclift

Copy link
Copy Markdown
Member

We'll probably want to keep the cron script that moves files into subdirectories automatically each month. 😄

@lucydodo

Copy link
Copy Markdown
Member Author

Good catch.
To add to that, I remove the code for the old arm64, intel builds and changed it to work for the universal builds.

@justinclift

Copy link
Copy Markdown
Member

Good thinking. I'd totally forgotten to make those changes to the actual cron script (a copy of this) on the nightlies server.

Hmmm, any interest in updating the script on the nightlies server too while you're at it? 😄

Comment thread installer/other/move_nightlies_into_dirs.sh Outdated
@lucydodo

Copy link
Copy Markdown
Member Author

Hmmm, any interest in updating the script on the nightlies server too while you're at it? 😄

Yes, I've modified it to match your review, so take a look and if you approve, I'll replace the script. :)

@justinclift justinclift left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me. 😄

@justinclift justinclift merged commit 4984963 into master Dec 11, 2023
@justinclift justinclift deleted the remove-scripts branch December 11, 2023 07:46
@lucydodo

Copy link
Copy Markdown
Member Author

Thanks, I've also replaced it on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants