Fixed Look and feel for snap packages using Env Variables #2217
Merged
Conversation
Changes from upstream
Signed-off-by: Navdeep Singh Sidhu <navdeepsingh.sidhu95@gmail.com>
Contributor
Author
|
@justinclift Please review changes. |
justinclift
reviewed
Apr 26, 2020
Member
|
Apart from that string weirdness, I'm not really sure what else to check. Guess we should merge this and see if things still work? 😄 |
Contributor
Author
|
that is weird for me as well. i am not fan of yaml files.
|
Member
|
No worries. Just merged it... lets see how it goes. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Look and feel for snap packages using Env Variables
Thanks to
https://github.com/popey/mgba-snap/pull/5/files