feat(sqlc): support emit_pointers_for_null_types for enums#3093
Open
godwhoa wants to merge 1 commit intosqlc-dev:mainfrom
Open
feat(sqlc): support emit_pointers_for_null_types for enums#3093godwhoa wants to merge 1 commit intosqlc-dev:mainfrom
godwhoa wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
Collaborator
|
I think this might not be enough. Do we not also need to modify the scanning code for the non-nullable enum types so that they properly return a nil pointer when they scan a Have you tried manually modifying the sqlc output to use pointers for nullable enums and confirmed that this proposed change alone does actually work as expected? |
Author
|
@andrewmbenton I did try with a basic |
2a551d4 to
304468b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.