Expect the to_char error for RN combined with other formats - #1353
Merged
mrigger merged 1 commit intoJul 31, 2026
Merged
Conversation
PostgreSQL rejects a numeric format string that combines RN with any other pattern, for example to_char(1.5, 'RN0'), with the error "RN" is incompatible with other formats. The expression generator can produce such format strings, so this error reached the caller as an unexpected one and aborted the test run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a run against postgres:18, a randomly generated
to_charcall was reported as a bug, although PostgreSQL rejected it correctly:The message was not registered as an expected error, so SQLancer stopped testing that database. This patch adds it to
getToCharFunctionErrors(), without the pattern name, so that the entry does not depend on which pattern raises it.Validating the format in the generator would mean reproducing the format parser of PostgreSQL, since the argument is built from concatenated expressions.
Testing
mvn packagepasses. A 40 second--oracle NORECrun against postgres:18 executed 2814 queries with no thread shutting down.