feat: include the target runtime in the get-hooks response - #26
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 12 12
Lines 227 227
=======================================
Hits 218 218
Misses 9 9 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Feb 21, 2024
WilliamBergamin
left a comment
Contributor
There was a problem hiding this comment.
Thank you 💯 been meaning to add this in
Member
Author
|
@WilliamBergamin thank you too! These are some pretty neat hooks 🐍 🪝 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the
runtimeattribute in theget-hooksresponse so that the CLI can recognize the runtime of a project.Special notes
I believe
pythonis the runtime andpython3is the executable, but please correct me if not!Requirements
./scripts/install_and_run_tests.shafter making the changes.