Allow class bound method works in app listener - #191
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 149 149
Lines 4448 4448
=======================================
Hits 4099 4099
Misses 349 349
Continue to review full report at Codecov.
|
|
Hi @liuyangc3, thanks a lot for taking the time to make this pull request. Although your change is not yet complete, it gave me a great insight for fixing the issue #174 (This is the issue you were trying to resolve. I gave up fixing this a while ago but I just reopened it). I sent another pull request #192 that resolves the issue for all patterns and added you to the co-authors in it (let me know if you don't want to be a co-author of the PR... hopefully not). Your contribution will be kept in the PR. Thus, please allow me to close this PR. If you have comments or feedback to #192, please feel free to write in. Thanks again for this contribution! 🙇 |
(Describe the goal of this PR. Mention any related Issue numbers)
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.