feature/SKED-6421: Add information about security to Pull Request Template - #2
Merged
Conversation
kendepelchin
reviewed
Oct 1, 2020
| In an effort to increase security awareness we want to remind ourselves to pay attention to security when writing code. | ||
| 👉 Mark this checkbox if you payed attention to security. | ||
| --> | ||
| - [ ] Security Awareness Checkbox 🛡️ |
There was a problem hiding this comment.
This will become "how to test" scenario very fast 😂
Contributor
There was a problem hiding this comment.
Suggested change
| - [ ] Security Awareness Checkbox 🛡️ | |
| - [x] Security Awareness Checkbox 🛡️ |
Saved you a click 😘
timothy-suy
suggested changes
Oct 1, 2020
timothy-suy
left a comment
Contributor
There was a problem hiding this comment.
Q: do we have a written down version of the security patterns somewhere (confluence, ...)?
If so, I'd add the link here
|
@timothy-suy we don't have a security patterns doc. |
|
I don't see the benefit of this; I think this will quickly become "tick the box" instead of actually thinking about this. |
timothy-suy
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JIRA: https://skedify.atlassian.net/browse/SKED-6421