Fix Firefox network idle timeout on repeated iterations#2391
Merged
Conversation
The WebSocket message listener for BiDi network events was never removed between iterations, causing listener leaks. Old listeners would decrement a stale inflight counter, driving it negative (-1), which prevented the idle check from ever succeeding. Store the handler as a named function and remove it on cleanup. Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com Change-Id: I2f8e7b72eb948332c54966aa18e7000128b5a110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebSocket message listener for BiDi network events was never removed between iterations, causing listener leaks.
Old listeners would decrement a stale inflight counter, driving it negative (-1), which prevented the idle check from ever succeeding. Store the handler as a named function and remove it on cleanup.
Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
Change-Id: I2f8e7b72eb948332c54966aa18e7000128b5a110