improvement(deployments): bugfixes for run-block, airtable + external sub management by icecrasher321 · Pull Request #5680 · simstudioai/sim

icecrasher321 · 2026-07-15T00:02:09Z

Summary

Make deployment status truthful end-to-end: deployments now move through an explicit state machine (preparing → activating → active / failed / superseded) backed by an outbox with inline-first execution, so a version is only reported live once its webhooks, schedules, and external subscriptions actually exist. Webhook registration is rebuilt on stable, generation-fenced rows with create-before-delete cutover — a failed deploy can no longer take down the currently live version, leave ghost registrations that wedge future deploys, or silently swallow provider errors (now surfaced in the deploy modal, versions list, and API responses).

Type of Change

Bug fix

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-15T00:02:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 15, 2026 3:11am

…ment-bugs # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

cursor · 2026-07-15T00:22:27Z

PR Summary

High Risk
Changes cut across deployment cutover, webhook registration/delivery, and background execution admission—areas where races or stale pins directly affect live traffic and multi-tenant isolation.

Overview
Deployment APIs, tools, and the deploy modal now treat isDeployed as “an active version snapshot exists” and expose activeDeployment plus latestDeploymentAttempt (preparing / activating / active / failed) instead of implying cutover finished on HTTP success. Chat updates and deploy/redeploy flows block until the attempt is active (409 while still preparing); the UI polls deployment info and version rows and shows pending/failed badges. Route-level PostHog deploy events are removed in favor of outbox-side effects.

Webhook and trigger execution gains generation-fenced stable registration (prepareStableTriggerWebhooksForDeploy), atomic path claims for cross-tenant collision resolution, a shared deliverable row predicate, and deploymentVersionId (plus schedule deploymentOperationId) carried into queued webhook/schedule/MCP runs so work pins the admitted version or skips when undeployed.

Smaller fixes: Airtable typecast on all write operations; condition else branches matched case-insensitively via shared helper; outbox handlers get an abort signal and safer persisted errors; workspace-fork rollback reactivation uses the async activation prep path.

^{Reviewed by Cursor Bugbot for commit 341b7e3. Configure here.}

icecrasher321 · 2026-07-15T01:11:06Z

bugbot run

icecrasher321 · 2026-07-15T01:11:10Z

@greptile

greptile-apps · 2026-07-15T01:14:06Z

Greptile Summary

This PR makes deployment status follow the real deployment lifecycle. The main changes are:

Operation-backed deploy preparation and activation.
Generation-fenced webhook registration and cleanup.
Pinned MCP execution against deployment snapshots.
Updated deployment API responses and UI status states.
Airtable typecast support for create and update tools.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/lib/webhooks/deploy.ts	Adds stable webhook preparation and version-scoped cleanup for deployment operations.
apps/sim/lib/workflows/deployment-outbox.ts	Adds deployment preparation, readiness checkpoints, activation, cleanup, and post-activation side effects.
apps/sim/lib/workflows/persistence/deployment-operations.ts	Adds deployment operation generation, status transitions, activation guards, and superseding behavior.
apps/sim/app/api/mcp/serve/[serverId]/route.ts	Pins MCP tool execution requests to the active deployment version at call time.
apps/sim/app/api/workflows/[id]/execute/route.ts	Restricts deployment snapshot execution to the internal MCP bridge path.

_{Reviews (2): Last reviewed commit: "address comments" | Re-trigger Greptile}

icecrasher321 · 2026-07-15T03:11:28Z

bugbot run

icecrasher321 · 2026-07-15T03:11:32Z

@greptile

cursor

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 341b7e3. Configure here.}

cursor · 2026-07-15T03:14:23Z

-
+  if (!prepared.success) {
+    throw new Error(prepared.error)
+  }


Idempotent reactivate skips failed ops

High Severity

prepareWorkflowVersionActivation treats any idempotent hit as success without checking operation status or calling onPrepareTransaction. A retry that reuses a failed, stuck preparing, or dead-lettered attempt restores the draft, returns success with no outboxEventId, and never re-enqueues cutover, so fork rollback can report restored while the version never goes live.

Additional Locations (1)

apps/sim/lib/workflows/persistence/deployment-operations.ts#L721-L730

^{Reviewed by Cursor Bugbot for commit 341b7e3. Configure here.}

cursor · 2026-07-15T03:14:23Z

+          eq(workflowDeploymentVersion.workflowId, workflow.id),
+          eq(workflowDeploymentVersion.isActive, true)
+        )
+      )


MCP still trusts isDeployed flag

Medium Severity

This change joins the active workflowDeploymentVersion to pin execution, but still admits MCP calls with workflow.isDeployed. The same PR’s deploy GET path already treats an active version snapshot as the source of truth because the legacy flag can disagree. Copilot check_deployment_status also reports isDeployed from the flag while attaching activeDeployment from the summary, so callers can see contradictory live state.

Additional Locations (1)

apps/sim/lib/copilot/tools/handlers/deployment/manage.ts#L72-L84

^{Reviewed by Cursor Bugbot for commit 341b7e3. Configure here.}

icecrasher321 added 2 commits July 14, 2026 13:15

improvement(webhooks): external subscription management

6382eb5

ui/ux

ff0aed0

icecrasher321 added 2 commits July 14, 2026 17:06

Merge remote-tracking branch 'origin/staging' into improvement/deploy…

cf11ff1

…ment-bugs # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx

remove test file

233b307

icecrasher321 marked this pull request as ready for review July 15, 2026 00:22

cursor Bot reviewed Jul 15, 2026

View reviewed changes

vercel Bot deployed to Preview July 15, 2026 00:26 View deployment

fix tests

bcc53f3

vercel Bot temporarily deployed to Preview July 15, 2026 01:10 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/app/api/chat/manage/[id]/route.ts

greptile-apps Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/persistence/deployment-operations.ts

Comment thread apps/sim/lib/workflows/deployment-outbox.ts

Comment thread apps/sim/lib/workflows/deployment-outbox.ts

Comment thread apps/sim/app/api/mcp/serve/[serverId]/route.ts

address comments

341b7e3

vercel Bot temporarily deployed to Preview July 15, 2026 03:11 Inactive

cursor Bot reviewed Jul 15, 2026

View reviewed changes

Uh oh!

Conversation

icecrasher321 commented Jul 15, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

icecrasher321 commented Jul 15, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 15, 2026

Choose a reason for hiding this comment

Idempotent reactivate skips failed ops

Uh oh!

cursor Bot Jul 15, 2026

Choose a reason for hiding this comment

MCP still trusts isDeployed flag

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 15, 2026 •

edited

Loading

cursor Bot commented Jul 15, 2026 •

edited

Loading

greptile-apps Bot commented Jul 15, 2026 •

edited

Loading