Skip to content

v0.7.35: sidebar styling, custom blocks reserved names fix, client env var checks#5674

Merged
icecrasher321 merged 3 commits into
mainfrom
staging
Jul 14, 2026
Merged

v0.7.35: sidebar styling, custom blocks reserved names fix, client env var checks#5674
icecrasher321 merged 3 commits into
mainfrom
staging

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

fix(sidebar): use emcn tooltip for workspace switcher disabled reasons (#5670)
fix(custom-blocks): reserve system output names, hide own block from command modal, constrain custom block image icons, and allow result as an exposed output name (#5667)
fix(upgrade): client-side env var check and self-hosted visibility fixes (#5673)

TheodoreSpeaks and others added 3 commits July 14, 2026 00:22
…om command modal (#5667)

* fix(custom-blocks): reserve system output names and hide own block from command modal

* fix(mothership): constrain custom block image icons in subagent tool rows

* improvement(custom-blocks): allow result as an exposed output name
* fix(upgrade): client side env var check

* fix misc self hosted visibility

* add tests
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 14, 2026 3:37pm

Request Review

@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes touch billing/org feature gating on the client, custom-block output semantics at execution time, and settings navigation visibility—moderate scope but not auth-critical; misaligned env twins could still skew client behavior.

Overview
Custom blocks reserve exposed output names success, error, and cost end-to-end (UI, Zod write schemas, publish/update ops, and executor projection) so user-defined fields cannot shadow billing or status. Published blocks carry sourceWorkflowId and are omitted from the workflow search palette on their source canvas to avoid recursive placement; copilot tool rows pin custom image icons to 14×14px.

Client configuration now evaluates isBillingEnabled, isAccessControlEnabled, and isOrganizationsEnabled from NEXT_PUBLIC_* / window.__ENV in the browser so flags match the server. Ollama availability in block utils uses the providers store when OLLAMA_URL is server-only.

Self-hosted / sidebar UX: account copilot settings redirect or hide when not hosted; workspace settings sidebar drops organization-plane links for non–org-admins (aligned with the org gate). Workspace switcher disabled actions use emcn tooltips instead of native title attributes.

Reviewed by Cursor Bugbot for commit db2fb3c. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates settings visibility, custom block output handling, and sidebar search behavior. The main changes are:

  • Client-aware environment checks for billing, organizations, and access control.
  • Reserved output-name validation for custom blocks.
  • Runtime projection of custom block system fields after curated outputs.
  • Search filtering to hide a workflow’s own custom block.
  • Sidebar and workspace header UI refinements.

Confidence Score: 5/5

This looks safe to merge after small cleanup around edge-case compatibility.

  • The changed runtime paths are mostly consistent.
  • Two conditional edge cases can produce confusing client behavior or changed legacy output values.
  • No blocking security or data-loss issue was found in the changed code.

apps/sim/lib/core/config/env-flags.ts and apps/sim/executor/handlers/workflow/workflow-handler.ts

Important Files Changed

Filename Overview
apps/sim/lib/core/config/env-flags.ts Adds browser-side reads from NEXT_PUBLIC_* feature flags, with a possible mismatch when only server-side vars are configured.
apps/sim/lib/api/contracts/custom-blocks.ts Adds write-time validation for reserved custom block output names while keeping reads lenient for older rows.
apps/sim/lib/workflows/custom-blocks/operations.ts Adds the same reserved-name validation to the operations layer for non-HTTP callers.
apps/sim/executor/handlers/workflow/workflow-handler.ts Ensures system fields win over curated outputs, which protects billing metadata but changes behavior for legacy reserved-name rows.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Filters a workflow’s own custom block from command search using the propagated source workflow id.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Moves disabled workspace action reasons from native titles into EMCN tooltips.

Reviews (1): Last reviewed commit: "fix(upgrade): client side env var check ..." | Re-trigger Greptile

Comment thread apps/sim/lib/core/config/env-flags.ts
Comment thread apps/sim/executor/handlers/workflow/workflow-handler.ts
@icecrasher321 icecrasher321 merged commit 91b29b3 into main Jul 14, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants