Skip to content

fix(sidebar): use emcn tooltip for workspace switcher disabled reasons#5670

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/tool-tip-create-workspace
Jul 14, 2026
Merged

fix(sidebar): use emcn tooltip for workspace switcher disabled reasons#5670
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/tool-tip-create-workspace

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Replace native title attribute tooltips on the workspace switcher menu items (New workspace, Invite teammates, Manage workspace) with the emcn Tooltip
  • Make the New workspace item non-interactive when workspace creation is disallowed — clicking no longer closes the menu or navigates to billing; it shows aria-disabled + canonical disabled chrome while keeping hover events alive for the tooltip

Type of Change

  • Bug fix

Testing

Tested manually; bun run lint:check and typecheck pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01NyKRdsNEQnwoENskFwWd41

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 14, 2026 3:20am

Request Review

@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Sidebar UX and accessibility only; no API, auth, or data-path changes.

Overview
Replaces native title tooltips on workspace switcher actions (New workspace, Invite teammates, Manage workspace) with a small DisabledReasonTooltip helper that uses emcn Tooltip when a policy reason exists.

New workspace when creation is blocked is now truly non-actionable: click no longer closes the menu or opens billing; it uses aria-disabled, muted chrome (cursor-not-allowed, reduced opacity), and keeps pointer events so the tooltip can show on hover.

Reviewed by Cursor Bugbot for commit 9a89a3e. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates disabled-reason tooltips in the workspace switcher. The main changes are:

  • Adds an EMCN Tooltip wrapper for disabled menu actions.
  • Replaces native title attributes on workspace actions.
  • Keeps the New workspace action hoverable while preventing creation when disallowed.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The Tooltip import path and Chip composition match the inspected component contracts.
  • The disabled New workspace path no longer opens the modal or navigates when creation is disallowed.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Adds tooltip-based disabled reasons for workspace switcher actions and updates New workspace disabled interaction.

Reviews (1): Last reviewed commit: "fix(sidebar): use emcn tooltip for works..." | Re-trigger Greptile

@TheodoreSpeaks TheodoreSpeaks merged commit 53bdbf4 into staging Jul 14, 2026
18 checks passed
@TheodoreSpeaks TheodoreSpeaks deleted the fix/tool-tip-create-workspace branch July 14, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant