improvement(url-state): shared sort/search url-state helpers + task and log selection deep links by waleedlatif1 · Pull Request #5652 · simstudioai/sim

waleedlatif1 · 2026-07-13T23:56:55Z

Stacked on #5648 — will retarget to staging once that merges.

Summary

Add shared URL-state primitives and migrate every consumer onto them (net −350 lines of duplication):
- createSortParams (lib/url-state) + useUrlSort — one definition of the sort+dir convention with defaulted and nullable modes; migrates tables, knowledge, knowledge docs, recently-deleted, logs, files, and the chunk view
- useDebouncedSearchSetter — the canonical debounced search-param setter; migrates 13 grouped/single sites and fixes a live bug where 5 surfaces wrote the trimmed value to a param controlling the input (typed trailing spaces were eaten, making multi-word search untypable)
- useSettingsSearch — collapses the 7 identical settings search bindings
Scheduled tasks: selected task moves from a useState object to a ?taskId= occurrence-id param (derive the object; Back closes the modal; mutation-driven closes use history: 'replace')
Logs: row click / Enter / sidebar next-prev / close now keep ?executionId in sync (history: 'replace'), so the deep link no longer goes stale after the first click
Chunk view (knowledge document): search + sort migrated to the URL — the last un-migrated sortable list
.claude/rules/sim-url-state.md + the you-might-not-need-url-state command updated to prescribe the shared helpers

Type of Change

Improvement

Testing

Typecheck + biome clean; multi-angle adversarial review applied (folder-sort parity, deleted-export sweep, trim-on-read audit across every consumer, menu-id ⊆ columns verified per surface)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-13T23:57:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Jul 14, 2026 12:57am

cursor · 2026-07-13T23:57:06Z

PR Summary

Medium Risk
Broad refactor across many list and settings screens touches shareable URL semantics and search/sort behavior; logs and scheduled-task selection changes affect deep-linking and browser history, though changes are mostly mechanical migrations to shared hooks.

Overview
Introduces createSortParams + useUrlSort and useDebouncedSearchSetter (plus useSettingsSearch for settings lists), then migrates tables, knowledge, files, logs, settings, landing pages, and related surfaces off duplicated inline nuqs wiring.

Search behavior fix: URL params now store the raw input value; filtering and API calls trim on read, so trailing spaces stay typable during multi-word search.

Deep links: Scheduled tasks use ?taskId= (derive task from loaded occurrences; Back closes modal). Logs keep ?executionId in sync on row click, keyboard nav, and sidebar close via history: 'replace. Knowledge document chunk view adds URL-backed search and sort.

Docs and the you-might-not-need-url-state command now mandate the shared helpers and flag re-implemented sort/search as an anti-pattern.

^{Reviewed by Cursor Bugbot for commit 9cea09d. Configure here.}

greptile-apps · 2026-07-13T23:59:31Z

Greptile Summary

This PR centralizes URL-backed search and sort behavior across the Sim app. The main changes are:

Shared helpers for debounced search params and sortable sort / dir params.
Migrated list, settings, files, logs, knowledge, tables, and chunk-view consumers.
URL-backed task selection for scheduled-task modal deep links.
URL-backed execution selection for log detail deep links.
Updated URL-state guidance and command docs.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/hooks/use-debounced-search-setter.ts	Adds the shared debounced search-param setter used by migrated search fields.
apps/sim/hooks/use-url-sort.ts	Adds shared URL sort wiring for defaulted and nullable sort modes.
apps/sim/lib/url-state/sort-params.ts	Adds the shared `sort` and `dir` parser factory.
apps/sim/app/workspace/[workspaceId]/scheduled-tasks/hooks/use-scheduled-tasks.ts	Moves selected scheduled-task occurrences into the `taskId` URL param.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx	Moves chunk search and sort state into the URL and trims the query before search.

_{Reviews (7): Last reviewed commit: "fix(url-state): reset chunk page in the ..." | Re-trigger Greptile}

waleedlatif1 · 2026-07-14T00:04:00Z

@greptile

waleedlatif1 · 2026-07-14T00:04:01Z

@cursor review

waleedlatif1 · 2026-07-14T00:18:35Z

@greptile

waleedlatif1 · 2026-07-14T00:18:36Z

@cursor review

waleedlatif1 · 2026-07-14T00:32:38Z

@greptile

waleedlatif1 · 2026-07-14T00:32:39Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

2 issues from previous reviews remain unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e6e6e01. Configure here.}

waleedlatif1 · 2026-07-14T00:38:47Z

@greptile

waleedlatif1 · 2026-07-14T00:38:48Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit c69fedd. Configure here.}

…nd log selection deep links

…ck, void settings search setter

… for task modal, unified executionId write path

… document schedules-refetch invariant

…r, trim chunk query read

waleedlatif1 · 2026-07-14T00:48:58Z

@greptile

waleedlatif1 · 2026-07-14T00:48:59Z

@cursor review

waleedlatif1 · 2026-07-14T00:56:52Z

@greptile

waleedlatif1 · 2026-07-14T00:56:53Z

@cursor review

cursor

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9cea09d. Configure here.}

greptile-apps Bot reviewed Jul 13, 2026

View reviewed changes

cursor Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx

vercel Bot deployed to Preview July 14, 2026 00:00 View deployment

vercel Bot temporarily deployed to Preview July 14, 2026 00:03 Inactive

greptile-apps Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/scheduled-tasks/hooks/use-scheduled-tasks.ts Outdated

cursor Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/scheduled-tasks/hooks/use-scheduled-tasks.ts Outdated

waleedlatif1 force-pushed the nuqs-url-state-helpers branch from 70dce27 to 5ad9d26 Compare July 14, 2026 00:17

cursor Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/use-settings-search.ts

Comment thread apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

vercel Bot deployed to Preview July 14, 2026 00:23 View deployment

vercel Bot temporarily deployed to Preview July 14, 2026 00:32 Inactive

cursor Bot reviewed Jul 14, 2026

View reviewed changes

waleedlatif1 force-pushed the nuqs-url-state-helpers branch from e6e6e01 to c69fedd Compare July 14, 2026 00:38

vercel Bot deployed to Preview July 14, 2026 00:42 View deployment

cursor Bot reviewed Jul 14, 2026

View reviewed changes

Base automatically changed from nuqs-url-state-fixes to staging July 14, 2026 00:46

waleedlatif1 added 4 commits July 13, 2026 17:47

improvement(url-state): shared sort/search url-state helpers + task a…

b53f194

…nd log selection deep links

improvement(url-state): audit fixes — cancel pending deep-link on cli…

1b7aaab

…ck, void settings search setter

fix(url-state): review fixes — trim-on-read filters, replace-on-close…

82fc9fb

… for task modal, unified executionId write path

improvement(url-state): final audit polish — consistent handler deps,…

e5d8cf5

… document schedules-refetch invariant

improvement(url-state): compose useSettingsSearch on the shared sette…

4810673

…r, trim chunk query read

waleedlatif1 force-pushed the nuqs-url-state-helpers branch from c69fedd to 4810673 Compare July 14, 2026 00:48

chore(skills): sync url-state skill edits through the canonical SKILL.md

a32ad56

vercel Bot deployed to Preview July 14, 2026 00:53 View deployment

cursor Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

fix(url-state): reset chunk page in the same write as a search change

9cea09d

vercel Bot temporarily deployed to Preview July 14, 2026 00:56 Inactive

cursor Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/scheduled-tasks/hooks/use-scheduled-tasks.ts

waleedlatif1 merged commit 3d67b50 into staging Jul 14, 2026
18 checks passed

waleedlatif1 deleted the nuqs-url-state-helpers branch July 14, 2026 01:08

waleedlatif1 mentioned this pull request Jul 14, 2026

v0.7.33: workflow/custom block fix, community pages improvements, chat animation #5658

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 13, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

waleedlatif1 commented Jul 14, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 13, 2026 •

edited

Loading

cursor Bot commented Jul 13, 2026 •

edited

Loading

greptile-apps Bot commented Jul 13, 2026 •

edited

Loading