Add attributemap claim2name.php to map MS .NET Framework Claim Types to Names#805
Open
gfaust-qb wants to merge 1 commit intosimplesamlphp:masterfrom
Open
Add attributemap claim2name.php to map MS .NET Framework Claim Types to Names#805gfaust-qb wants to merge 1 commit intosimplesamlphp:masterfrom
gfaust-qb wants to merge 1 commit intosimplesamlphp:masterfrom
Conversation
Author
|
Hi, I don't know why codeclimate fails, log shows nothing depending to this file. Guido |
tvdijen
approved these changes
Mar 6, 2018
Member
|
Thanks @gfaust-qb ! Very useful!! |
tvdijen
requested changes
Mar 6, 2018
Member
tvdijen
left a comment
There was a problem hiding this comment.
To get to your question.. I think you should use the names of the AD attributes..
So you would use c instead of country for example
Author
|
Thank you! I opened an Issue (#807) to discuss this and to offer my help to generate an mapping overview. Guido |
Maps Microsoft .NET Framework ClaimTypes to Names Names in this version are used as described by Microsoft. @see https://msdn.microsoft.com/en-us/library/hh159803.aspx
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=========================================
Coverage 38.36% 38.36%
Complexity 3385 3385
=========================================
Files 128 128
Lines 9633 9633
=========================================
Hits 3696 3696
Misses 5937 5937 |
1c686ab to
eb20457
Compare
08ebb9c to
64fca25
Compare
7a53fc8 to
d73ae47
Compare
e5c0e21 to
d5616df
Compare
2e6ab04 to
32f9acc
Compare
7e3ea19 to
2523634
Compare
7b173cf to
3326beb
Compare
8ac729b to
a16cf6e
Compare
fc454de to
7ac76ae
Compare
29f7b69 to
1a911ce
Compare
c7c8357 to
fdbe001
Compare
3b5f5ba to
96357ee
Compare
d7f25d2 to
41d9254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
second, clean try ;)
I needed a mapping for claim types to names several times and started to create my own attributemap.
I added an attributemap that maps Microsoft .NET Framework (standard) ClaimTypes to Names.
At the moment Names are used as used by Microsoft in their description.
@see https://msdn.microsoft.com/en-us/library/hh159803.aspx
I recognized that these Names do not map to the names in name2claim.php or other attributemaps - but that there are inconsistencies in other mappings also.
Do you have a suggestion what Names I should use to make a valuable contribution to this project?
Guido