Skip to content

Add ability to override execAsync's maxBuffer default of 20MiB - #270

Closed
pieterjandesmedt wants to merge 0 commit into
shelljs:masterfrom
pieterjandesmedt:master
Closed

Add ability to override execAsync's maxBuffer default of 20MiB#270
pieterjandesmedt wants to merge 0 commit into
shelljs:masterfrom
pieterjandesmedt:master

Conversation

@pieterjandesmedt

Copy link
Copy Markdown

A maxBuffer of 20 MiB is not enough when you use for example a cut command on a multi-gigabyte file.

@nfischer

nfischer commented Jan 5, 2016

Copy link
Copy Markdown
Member

It might help if you add this change to the documentation. https://github.com/pieterjandesmedt/shelljs/blob/master/src/exec.js#L167

Also, if you could add an example to the docs, that would probably be good as well.

@pieterjandesmedt

Copy link
Copy Markdown
Author

maxBuffer option documentation and example added to README and source code

@nfischer

nfischer commented Jan 6, 2016

Copy link
Copy Markdown
Member

👍

@pieterjandesmedt

Copy link
Copy Markdown
Author

No problem. Are you going to merge these?

@nfischer

nfischer commented Jan 8, 2016

Copy link
Copy Markdown
Member

I unfortunately don't have access to the repo. I think only @arturadib does. I'm just trying to review the PRs and issues that I can, so that it's easier to merge things when the project starts getting maintained.

I'm maintaining my own fork (https://github.com/nfischer/shelljs) right now, since this project doesn't seem to be maintained. If you open a PR from this branch to my fork, I'll double check and then merge it.

Be warned, my fork has some extra features that aren't yet merged into this repo, but I think they're useful features that will be appreciated (and will hopefully be merged upstream).

@nfischer

Copy link
Copy Markdown
Member

@pieterjandesmedt could you rebase this off master? This should be something we can merge fairly soon.

@pieterjandesmedt

Copy link
Copy Markdown
Author

Like this? #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants