Skip to content

[WIP] Try to preserve supplied options.async - #184

Closed
vise890 wants to merge 1 commit into
shelljs:masterfrom
vise890:master
Closed

[WIP] Try to preserve supplied options.async#184
vise890 wants to merge 1 commit into
shelljs:masterfrom
vise890:master

Conversation

@vise890

@vise890 vise890 commented Feb 1, 2015

Copy link
Copy Markdown
Contributor

Hi there,

Say, I ran this code:

var sh = require('shelljs');

sh.exec("sleep 0.5", {async: false}, function() {
    sh.echo("print first");
});

sh.echo("print last");

...as output, I will get:

print last
print first

Your documentation on shelljs.org seems to imply that if you pass in an {async:false} as options, you still get to run code synchronously.

Cheers. M.

@vise890 vise890 mentioned this pull request Feb 1, 2015
@vise890 vise890 changed the title [RFC] Preserve supplied options.async Preserve supplied options.async Feb 1, 2015
@vise890 vise890 closed this Feb 2, 2015
@vise890 vise890 changed the title Preserve supplied options.async [WIP] Try to preserve supplied options.async Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant