Skip to content

Adhere to Serverless.yml exclude list #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QAnders wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −7
Open

Adhere to Serverless.yml exclude list #13097

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6faf6
Adhere to Serverless.yml exckude list
QAnders Jun 25, 2025
95a861a
Fixing optional chainig
QAnders Jun 25, 2025
82d2f11
Adding log for failed packaging
QAnders Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions lib/plugins/package/lib/zip-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default {
log.info('Excluding development dependencies')
}

const exAndInNode = await excludeNodeDevDependenciesMemoized(serviceDir)
const exAndInNode = await excludeNodeDevDependenciesMemoized(serviceDir, this)
params.exclude = _.union(params.exclude, exAndInNode.exclude)
params.include = _.union(params.include, exAndInNode.include)
params.devDependencyExcludeSet = new Set(exAndInNode.exclude)
Expand Down Expand Up @@ -163,7 +163,7 @@ export default {
},
}

async function excludeNodeDevDependencies(serviceDir) {
async function excludeNodeDevDependencies(serviceDir, cachedThis) {
const exAndIn = {
include: [],
exclude: [],
Expand All @@ -178,12 +178,17 @@ async function excludeNodeDevDependencies(serviceDir) {
`node-dependencies-${randHash}-prod`,
)

// Adhere to excluded patterns from serverless.yml!
// If we have access issues, e.g. Docker as `root` we must exclude what the user has set to exclude
// as this is set to fail silently, we'll include all devDependencies otherwise!
// `patterns` has e.g. '!coverage/**', but globby needs '!**/coverage' so we'll transform the pattern
const globPatterns = cachedThis.serverless.service?.package?.patterns?.flatMap((pattern) => pattern?.[0] === '!'
? pattern.replace(/^!([\w\-\/\\.]+)\/\*\*/, '!**/$1') : []) || [];
globPatterns.unshift('**/package.json') // includes must come before excludes

try {
const packageJsonFilePaths = globby.sync(
[
'**/package.json',
// TODO add glob for node_modules filtering
],
globPatterns,
{
cwd: serviceDir,
dot: true,
Expand Down Expand Up @@ -346,7 +351,8 @@ async function excludeNodeDevDependencies(serviceDir) {
})
)
} catch (e) {
// fail silently
console.error(`Excluding/including files/directories in packaging has failed.
Most likely reason is permission issues. Error encountered:`, e.message);
return Promise.resolve(exAndIn)
}
}