feat: improvement to allow the use of differents content types#575
Merged
camilamaia merged 3 commits intomainfrom Mar 16, 2023
Merged
feat: improvement to allow the use of differents content types#575camilamaia merged 3 commits intomainfrom
camilamaia merged 3 commits intomainfrom
Conversation
|
@uesleicarvalhoo your pull request is missing a changelog! |
f27b2a0 to
01e517c
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 97.85% 97.86% +0.01%
==========================================
Files 24 24
Lines 745 751 +6
==========================================
+ Hits 729 735 +6
Misses 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
01e517c to
1988ebf
Compare
Crocmagnon
suggested changes
Mar 9, 2023
camilamaia
reviewed
Mar 9, 2023
Crocmagnon
suggested changes
Mar 11, 2023
64920aa to
51aa84c
Compare
camilamaia
reviewed
Mar 14, 2023
| allow_redirects=False, | ||
| ) | ||
|
|
||
| test_content_types = [ |
| ) | ||
|
|
||
| @staticmethod | ||
| def _content_type_is_json(headers): |
Crocmagnon
suggested changes
Mar 14, 2023
Contributor
Crocmagnon
left a comment
There was a problem hiding this comment.
Still a couple of conversations open
camilamaia
approved these changes
Mar 15, 2023
Member
camilamaia
left a comment
There was a problem hiding this comment.
Nice, this is a really cool feature! Thanks for implementing it @uesleicarvalhoo!
It is up to you to implement the suggested tests, but either way, at least for me, it is already good to go 🚀
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
Co-authored-by: Gabriel Augendre <gabriel@augendre.info>
b786c37 to
bf2cadc
Compare
Crocmagnon
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change request to use
dataparameter instead ofjsonand setapplication/jsonas defaultContent-TypeMotivation behind this PR?
This issue #521
What type of change is this?
Feature
Checklist
Issue
Closes #521