refactor(report): cleanup chrome fix (#551)#574
Conversation
|
@Crocmagnon your pull request is missing a changelog! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 23 23
Lines 743 743
=======================================
Hits 729 729
Misses 14 14 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Pradhvan
left a comment
There was a problem hiding this comment.
Seems like the way to go on reading a bit on textContent.
|
@Crocmagnon can you also add a changelong entry please. 😄 |
|
@Pradhvan since it is just a refactor with no impacts for the final user), I believe a changelog entry is not needed. https://github.com/scanapi/scanapi/wiki/Changelog#what-warrants-a-changelog-entry |
6efecec to
fe681ff
Compare
|
Ah well that's what I thought too but I added one before seeing Camila's message 😅 |
|
@Crocmagnon no worries! I can remove it before merging :) Thanks! |
|
@camilamaia your pull request is missing a changelog! |
Cleanup code linked to Chrome fix, turns out
.textContentis all we need.Tested on macOS on Safari, Chrome & Firefox.