Skip to content

fix: content field didn't render properly on Chrome#568

Merged
camilamaia merged 1 commit intomainfrom
fix-content-chrome
Mar 3, 2023
Merged

fix: content field didn't render properly on Chrome#568
camilamaia merged 1 commit intomainfrom
fix-content-chrome

Conversation

@Crocmagnon
Copy link
Copy Markdown
Contributor

@Crocmagnon Crocmagnon commented Mar 3, 2023 •
edited
Loading

Description

Fix the issue linked + a bit of cleanup of the code around

Motivation behind this PR?

Fix #551

What type of change is this?

bugfix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #551

@Crocmagnon Crocmagnon requested review from a team as code owners March 3, 2023 16:43
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #568 (7d0fef1) into main (81ec5ec) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          23       23           
  Lines         743      743           
=======================================
  Hits          729      729           
  Misses         14       14

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Crocmagnon Crocmagnon changed the title fix: content field didn't render properly on Chrome (#551) fix: content field didn't render properly on Chrome Mar 3, 2023
camilamaia
camilamaia approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Magic Gif

@camilamaia camilamaia merged commit 6560664 into main Mar 3, 2023
@camilamaia camilamaia deleted the fix-content-chrome branch March 3, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Field Content is not being displayed properly on Chrome

3 participants

@Crocmagnon @codecov-commenter @camilamaia