Skip to content

fix: custom variable evaluated when defined on the path (#508)#556

Merged
camilamaia merged 1 commit intomainfrom
unknown repository
Feb 28, 2023
Merged

fix: custom variable evaluated when defined on the path (#508)#556
camilamaia merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 21, 2022

Description

Custom variable will be evaluated when defined in the path

Motivation behind this PR?

#508

What type of change is this?

Bug fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #508

@ghost ghost requested review from a team as code owners November 21, 2022 17:44
github-actions[bot]
github-actions bot reviewed Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@github-actions github-actions bot added the First Contribution First contribution to the project. label Nov 21, 2022
fix: custom variable evaluated when defined on the path (#508)
2b0bd6e 
fix(pre-commit:flake8): The repository in gitlab no longer exists
camilamaia
camilamaia approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Comment thread .pre-commit-config.yaml
hooks:
- id: isort
- repo: https://gitlab.com/pycqa/flake8
- repo: https://github.com/pycqa/flake8
Copy link
Copy Markdown
Member

@camilamaia camilamaia Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 nice catch!

@camilamaia camilamaia merged commit d52dd88 into scanapi:main Feb 28, 2023
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Feb 28, 2023

@taconi Congrats on your first PR merged! 🌟 Thank you very much!

I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works.

Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them.

Welcome on board and once again, thank you! 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

First Contribution First contribution to the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom variable not being evaluated when defined in the same request

1 participant

@camilamaia