Skip to content

feat: After the process run print a test summary in console#542

Merged
astenstrasser merged 14 commits intomainfrom
538-2
Apr 22, 2022
Merged

feat: After the process run print a test summary in console#542
astenstrasser merged 14 commits intomainfrom
538-2

Conversation

@astenstrasser
Copy link
Copy Markdown
Member

@astenstrasser astenstrasser commented Apr 14, 2022

Description

image
image

Motivation behind this PR?

As discussed on #518

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #538

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2022

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.90%. Comparing base (1f35d3d) to head (7c89710).
⚠️ Report is 171 commits behind head on main.

Files with missing lines Patch % Lines
scanapi/scan.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   97.07%   97.90%   +0.83%     
==========================================
  Files          22       23       +1     
  Lines         717      717              
==========================================
+ Hits          696      702       +6     
+ Misses         21       15       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astenstrasser astenstrasser marked this pull request as draft April 15, 2022 20:40
@astenstrasser astenstrasser force-pushed the 538-2 branch 2 times, most recently from 87be8f5 to 46beba5 Compare April 20, 2022 18:24
@astenstrasser astenstrasser marked this pull request as ready for review April 20, 2022 18:29
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astenstrasser hey, thanks for the awesome PR. Great feature and really clean up. I left only some minor suggestions.

It looks great overall ⭐

Comment thread scanapi/evaluators/code_evaluator.py Outdated
# Available imports to be used dinamically in the API spec
import datetime # noqa: F401
import logging
import logging # noqa: F401
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove this line? I believe it is not being used

@@ -1,11 +1,8 @@
import logging
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹🧹🧹

Comment thread scanapi/console.py Outdated
_write_summary()


def log_report(uri):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this method name to something like print_report_path or write_report_path for consistency. Because I would assume that a log_report method would use a log object to log something and not a console to print. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rich for summary in the console

4 participants