Skip to content

fix: deepsource issues#532

Merged
astenstrasser merged 2 commits intomainfrom
530
Apr 9, 2022
Merged

fix: deepsource issues#532
astenstrasser merged 2 commits intomainfrom
530

Conversation

@astenstrasser
Copy link
Copy Markdown
Member

@astenstrasser astenstrasser commented Apr 9, 2022 •
edited
Loading

Description

Fix deep source issues:

  • inconsistent return statements
  • line too long

What type of change is this?

Fix pipeline

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

#530

@astenstrasser astenstrasser requested review from a team as code owners April 9, 2022 12:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2022

@astenstrasser your pull request is missing a changelog!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #532 (859f3ff) into main (922afe0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   97.07%   97.07%   -0.01%     
==========================================
  Files          22       22              
  Lines         718      717       -1     
==========================================
- Hits          697      696       -1     
  Misses         21       21
Impacted Files Coverage Δ
scanapi/errors.py 100.00% <100.00%> (ø)
scanapi/template_render.py 100.00% <100.00%> (ø)
scanapi/tree/endpoint_node.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922afe0...859f3ff. Read the comment docs.

@astenstrasser astenstrasser changed the title 530 fix: deepsource issues Apr 9, 2022
@astenstrasser astenstrasser merged commit e9fa4cf into main Apr 9, 2022
@astenstrasser astenstrasser deleted the 530 branch April 9, 2022 12:24
This was referenced Apr 10, 2022
Closed
Closed
astenstrasser added a commit that referenced this pull request Apr 14, 2022
@astenstrasser
fix: deepsource issues (#532)
69aeea7 
* fix: inconsistent return statements

* fix: line too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astenstrasser @codecov-commenter @camilamaia