Skip to content

[530] Fix deepsource issues#531

Merged
astenstrasser merged 4 commits intomainfrom
530
Apr 9, 2022
Merged

[530] Fix deepsource issues#531
astenstrasser merged 4 commits intomainfrom
530

Conversation

@astenstrasser
Copy link
Copy Markdown
Member

@astenstrasser astenstrasser commented Apr 9, 2022 •
edited
Loading

Description

Fix deep source issues:

  • empty file
  • unnecessary pass statement
  • too general exception
  • wrong import

What type of change is this?

Fix pipeline

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

#530

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2022

@astenstrasser your pull request is missing a changelog!

@astenstrasser astenstrasser changed the title fix: removes empty file 530 - Fix deepsource issues Apr 9, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #531 (57db77c) into main (b4bf619) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   96.94%   97.07%   +0.13%     
==========================================
  Files          22       22              
  Lines         720      719       -1     
==========================================
  Hits          698      698              
+ Misses         22       21       -1
Impacted Files Coverage Δ
scanapi/__main__.py 100.00% <ø> (+3.22%) ⬆️
scanapi/errors.py 100.00% <ø> (ø)
scanapi/tree/endpoint_node.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bf619...57db77c. Read the comment docs.

@astenstrasser astenstrasser changed the title 530 - Fix deepsource issues [530] Fix deepsource issues Apr 9, 2022
camilamaia
camilamaia approved these changes Apr 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@astenstrasser astenstrasser marked this pull request as ready for review April 9, 2022 11:08
@astenstrasser astenstrasser requested review from a team as code owners April 9, 2022 11:08
@astenstrasser astenstrasser merged commit 922afe0 into main Apr 9, 2022
@astenstrasser astenstrasser deleted the 530 branch April 9, 2022 11:09
@camilamaia camilamaia mentioned this pull request Apr 10, 2022
Closed
astenstrasser added a commit that referenced this pull request Apr 14, 2022
@astenstrasser
fix: deepsource issues (#531)
a227a84 
* fix: removes empty file
* fix: remove unnecessary pass
* fix: remove general exception
* fix: wrong import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astenstrasser @codecov-commenter @camilamaia