Skip to content

Run lint on push#520

Merged
Pradhvan merged 1 commit intomainfrom
issue490-run-lint-on-push
Oct 6, 2021
Merged

Run lint on push#520
Pradhvan merged 1 commit intomainfrom
issue490-run-lint-on-push

Conversation

@JRubics
Copy link
Copy Markdown
Member

@JRubics JRubics commented Oct 6, 2021

Description

Enable lint action to run on pushes to the main branch. Previously, it was only running in the PRs.
Added status badge for showing if the lint check on main branch is passing.

Motivation behind this PR?

closes #490
Improves visibility of lint status

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #490

@JRubics JRubics requested review from a team as code owners October 6, 2021 11:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2021

@JRubics your pull request is missing a changelog!

@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 6, 2021

If accepted, please tag my contribution with the label hacktoberfest-accepted :)

Pradhvan
Pradhvan approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Oct 6, 2021

@JRubics added a label on the issue. 😄

@Pradhvan Pradhvan merged commit f974b4e into main Oct 6, 2021
@Pradhvan Pradhvan deleted the issue490-run-lint-on-push branch October 6, 2021 15:03
@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 7, 2021

Thanks! Label should be added on PR, can you please add it here too? :)

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Oct 7, 2021

@JRubics done 😄

@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 7, 2021

Thanks! 🎉

camilamaia pushed a commit that referenced this pull request Apr 8, 2022
@JRubics @JelenaDokic @camilamaia
ci: run lint on push (#520)
dd0aa7f 
Co-authored-by: Jelena Dokic <jelena.dokic@symphony.is>
astenstrasser pushed a commit that referenced this pull request Apr 14, 2022
@JRubics @JelenaDokic @astenstrasser
ci: run lint on push (#520)
26be044 
Co-authored-by: Jelena Dokic <jelena.dokic@symphony.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable lint action to also run on pushes to the main branch

3 participants

@JRubics @Pradhvan @JelenaDokic