Skip to content

Run examples on push#519

Merged
astenstrasser merged 1 commit intomainfrom
issue491-run-examples-on-push
May 5, 2022
Merged

Run examples on push#519
astenstrasser merged 1 commit intomainfrom
issue491-run-examples-on-push

Conversation

@JRubics
Copy link
Copy Markdown
Member

@JRubics JRubics commented Oct 6, 2021 •
edited
Loading

Description

Enable run examples action to run on pushes to the main branch. Previously, it was only running in the PRs.
Added status badge for showing if the examples on main branch are running properly.

Motivation behind this PR?

closes #491
Improves visibility of examples status

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #491

@JRubics JRubics requested review from a team as code owners October 6, 2021 09:40
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2021

@JRubics your pull request is missing a changelog!

@JRubics JRubics self-assigned this Oct 6, 2021
@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 6, 2021

If accepted, please tag my contribution with the label hacktoberfest-accepted :)

@JRubics JRubics force-pushed the issue491-run-examples-on-push branch from 70eb519 to 185c1c2 Compare October 6, 2021 11:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #519 (fd9984a) into main (d63fc26) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          23       23           
  Lines         717      717           
=======================================
  Hits          702      702           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63fc26...fd9984a. Read the comment docs.

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Oct 6, 2021

@JRubics Thank You for taking this up. I have added the label on the issue as hacktoberfest-accepted .

Also there are some conflicts in the PR. Can you please fix those?

@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 7, 2021

Thank you, there are some conflicts since I change pretty similar things in both PR-s I made, I will fix them now :)
And can you please add label to the PR too since on issue it is not enough? Thanks in advice! :)

@JRubics JRubics force-pushed the issue491-run-examples-on-push branch from 185c1c2 to 258b840 Compare October 7, 2021 09:28
@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 15, 2021

Fixed :)

astenstrasser
astenstrasser suggested changes Apr 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@astenstrasser astenstrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JRubics! Thanks for your PR.
Your commits are fine, but I see there are some other changes on the PR.
Could you please adjust so we only have your commits?
Thanks a lot :)

@JRubics JRubics force-pushed the issue491-run-examples-on-push branch from 258b840 to fd9984a Compare May 3, 2022 15:18
@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented May 3, 2022

Done :)

@astenstrasser astenstrasser merged commit 788060b into main May 5, 2022
@astenstrasser astenstrasser deleted the issue491-run-examples-on-push branch May 5, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@astenstrasser astenstrasser astenstrasser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JRubics JRubics

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable run examples action to also run on pushes to the main branch

5 participants

@JRubics @codecov-commenter @Pradhvan @astenstrasser @JelenaDokic