Adr2/update report html UI#506
Merged
astenstrasser merged 7 commits intoscanapi:mainfrom Apr 10, 2022
Merged
Conversation
update report classes following BEMCSS pattern close unclosed html tags
UI details include: 1. add Gotham Font Family; 2. Variables CSS with colors; 2.1. Update red color to use: #f14668; 2.2. Update green color to use: #48c78e; 3. Add visual wrapper to following areas: request content, request response and request test; 4. New endpoint status UI;
Member
|
Hey, @GitVitor, thank you very much for the PR 🙌 I run the branch on my local machine and tested it using Chrome, Firefox, and Safari. I made a circle in the improvements points I found. In Safari, there is some information missing, for example. There are other small issues related to alignment, space... Let me know what do you think! ChromeVersion 93.0.4577.63 (Official Build) (x86_64)
Firefox91.0 (64-bit)
SafariVersion 14.1.2 (16611.3.10.1.6)
|
Member
|
@GitVitor hey 👋🏾 are you still working on this ? |
Contributor
Author
|
Hello folks, sorry i was busy in last month. I will work on this in next days. |
astenstrasser
suggested changes
Apr 10, 2022
astenstrasser
approved these changes
Apr 10, 2022
astenstrasser
added a commit
that referenced
this pull request
Apr 10, 2022
* update report summary test location update report classes following BEMCSS pattern close unclosed html tags * feat: add new UI details to report HTML UI details include: 1. add Gotham Font Family; 2. Variables CSS with colors; 2.1. Update red color to use: #f14668; 2.2. Update green color to use: #48c78e; 3. Add visual wrapper; 4. New endpoint status UI; * fix: revert font change * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Alexandra Monteiro Stenstrasser <astenstrasser@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UI change:
1. add Gotham Font Family;
2. Variables CSS with colors;
2.1. Update red color to use: #f14668;
2.2. Update green color to use: #48c78e;
3. Add visual wrapper to following areas: request content, request response and request test;
4. New endpoint status UI;
Motivation behind this PR?
Following recent discussions on #161 we decide to implement new details to help users on visualize related request data.
What type of change is this?
Feature
Checklist
Issue
#161