Skip to content

docs: add docstring to endpoint_node#505

Merged
camilamaia merged 1 commit intoscanapi:mainfrom
gabrieltron:add-docs-to-endpoint_node
Aug 31, 2021
Merged

docs: add docstring to endpoint_node#505
camilamaia merged 1 commit intoscanapi:mainfrom
gabrieltron:add-docs-to-endpoint_node

Conversation

@gabrieltron
Copy link
Copy Markdown
Member

@gabrieltron gabrieltron commented Aug 31, 2021

Description

Add missing docstrings to endpoint_node.py.

Motivation behind this PR?

What type of change is this?

Documentation

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #444

@gabrieltron gabrieltron requested review from a team as code owners August 31, 2021 04:07
@github-actions github-actions bot added the First Contribution First contribution to the project. label Aug 31, 2021
github-actions[bot]
github-actions bot reviewed Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@camilamaia camilamaia merged commit 204e73a into scanapi:main Aug 31, 2021
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Aug 31, 2021

Congrats on your first PR merged, @gabrieltron! 🌟 Thank you very much!

I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works.

Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them.

Welcome on board and once again, thank you! 🙇‍♀️

camilamaia pushed a commit that referenced this pull request Apr 8, 2022
@gabrieltron @camilamaia
docs: add docstring to endpoint_node (#505)
8fadb7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

First Contribution First contribution to the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the missing docstrings to the endpoint_node.py file

2 participants

@gabrieltron @camilamaia