Skip to content

Add a --browse option in CLI#496

Merged
renato04 merged 1 commit intomainfrom
browseOption
Aug 16, 2021
Merged

Add a --browse option in CLI#496
renato04 merged 1 commit intomainfrom
browseOption

Conversation

@renato04
Copy link
Copy Markdown
Contributor

@renato04 renato04 commented Aug 13, 2021

Description

I added a new option to open the report result on a browser.

Motivation behind this PR?

Closes #465

What type of change is this?

It is a new feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #465

@renato04 renato04 requested review from a team as code owners August 13, 2021 20:26
Pradhvan
Pradhvan requested changes Aug 14, 2021
View reviewed changes
Comment thread scanapi/scan.py Outdated
Comment thread scanapi/settings.py Outdated
@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Aug 14, 2021

@renato04 great job ⭐ Just left some minor comments for the static analysis to pass.

@renato04
Copy link
Copy Markdown
Contributor Author

renato04 commented Aug 14, 2021

Thanks @Pradhvan I'll fix it as soon as possible

@renato04
Copy link
Copy Markdown
Contributor Author

renato04 commented Aug 16, 2021

@Pradhvan I fixed it!

Pradhvan
Pradhvan approved these changes Aug 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾 @camilamaia what do you think ?

@Pradhvan Pradhvan requested a review from camilamaia August 16, 2021 13:16
@hebertjulio
Copy link
Copy Markdown
Member

hebertjulio commented Aug 16, 2021

Look good to me. Browser open with successful! 🚀 😄

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Aug 16, 2021

Look good to me. Browser open with successful! rocket smile

Great! Thanks @hebertjulio for reviewing it. Feel free to approve the PR. 😄

@renato04 renato04 merged commit c03cbba into main Aug 16, 2021
@renato04 renato04 deleted the browseOption branch August 16, 2021 15:15
@camilamaia camilamaia mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hebertjulio hebertjulio hebertjulio approved these changes

@Pradhvan Pradhvan Pradhvan approved these changes

@camilamaia camilamaia Awaiting requested review from camilamaia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UX / CLI: add a --browse option

3 participants

@renato04 @Pradhvan @hebertjulio