Skip to content

Fix: Break lines in column to prevent overflow#432

Merged
camilamaia merged 1 commit intoscanapi:mainfrom
bartvanherck:409
Jul 30, 2021
Merged

Fix: Break lines in column to prevent overflow#432
camilamaia merged 1 commit intoscanapi:mainfrom
bartvanherck:409

Conversation

@bartvanherck
Copy link
Copy Markdown
Contributor

@bartvanherck bartvanherck commented Jul 29, 2021 •
edited by Pradhvan
Loading

  • Use break-all css in the right columns of the table to prevent overflow,
  • Update the Changelog

Description

Fix for issue #409

Motivation behind this PR?

in some html tables when there is long data, the data gets out of the table

What type of change is this?

Bug Fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.

Issue

Closes 409

@bartvanherck bartvanherck requested a review from a team as a code owner July 29, 2021 05:42
@Pradhvan Pradhvan changed the title Fix: Break lines in column to prevent overflow (#409) Fix: Break lines in column to prevent overflow Jul 29, 2021
Pradhvan
Pradhvan requested changes Jul 29, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
@bartvanherck
Fix: Break lines in column to prevent overflow
c6c7035 
- Use break-all css in the right columns of the table to prevent overflow,
- Update the Changelog

Closes #409
Pradhvan
Pradhvan approved these changes Jul 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾 @hebertjulio @camilamaia can you check this please too.

@hebertjulio
Copy link
Copy Markdown
Member

hebertjulio commented Jul 29, 2021

LGTM 👍🏾 @hebertjulio @camilamaia can you check this please too.

Thanks @Pradhvan , I checked this and look good to me.

@camilamaia camilamaia merged commit 31c5d27 into scanapi:main Jul 30, 2021
@bartvanherck bartvanherck deleted the 409 branch July 30, 2021 15:44
@camilamaia camilamaia mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartvanherck @hebertjulio @Pradhvan @camilamaia