Skip to content

Fix making request that has no body and there is a hide_request::body config#393

Merged
camilamaia merged 2 commits intomasterfrom
392
Jun 8, 2021
Merged

Fix making request that has no body and there is a hide_request::body config#393
camilamaia merged 2 commits intomasterfrom
392

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented Jun 7, 2021 •
edited
Loading

Description

Fix error making request when request has no body and there is a report::hide_request::body configuration.

Motivation behind this PR?

Closes #392

What type of change is this?

Bug fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.

Issue

Closes 392

@camilamaia camilamaia requested review from a team as code owners June 7, 2021 21:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 7, 2021

@camilamaia your pull request is missing a changelog!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #393 (2991fce) into master (416249a) will increase coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   95.77%   95.87%   +0.09%     
==========================================
  Files          22       22              
  Lines         663      678      +15     
==========================================
+ Hits          635      650      +15     
  Misses         28       28
Impacted Files Coverage Δ
scanapi/hide_utils.py 97.26% <92.85%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416249a...2991fce. Read the comment docs.

@camilamaia camilamaia requested a review from hebertjulio June 8, 2021 14:41
Pradhvan
Pradhvan approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@camilamaia camilamaia merged commit 0d27502 into master Jun 8, 2021
@camilamaia camilamaia deleted the 392 branch June 8, 2021 14:46
@camilamaia camilamaia mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

@hebertjulio hebertjulio Awaiting requested review from hebertjulio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error making request when request has no body and there is a report::hide_request::body configuration.

3 participants

@camilamaia @codecov-commenter @Pradhvan