Skip to content

Fix Changelog Lint job#391

Merged
camilamaia merged 1 commit intomasterfrom
389
Jun 8, 2021
Merged

Fix Changelog Lint job#391
camilamaia merged 1 commit intomasterfrom
389

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented Jun 7, 2021 •
edited
Loading

Description

Changelog Lint Workflow is failing on master.. This PR fixes it.

Motivation behind this PR?

Added a missing # to the Added section, in order to make the changelog lint pass. We want to have the changelog file always in the same format to keep the consistence.

What type of change is this?

Bug fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • N/A - I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • N/A - I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • N/A - I have run ScanAPI locally and manually tested my changes. Instructions.

Issue

Closes #389

@camilamaia camilamaia self-assigned this Jun 7, 2021
@camilamaia camilamaia marked this pull request as ready for review June 7, 2021 17:27
@camilamaia camilamaia requested review from a team as code owners June 7, 2021 17:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #391 (d52a859) into master (67ac683) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          22       22           
  Lines         663      663           
=======================================
  Hits          635      635           
  Misses         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ac683...d52a859. Read the comment docs.

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Jun 8, 2021

LGTM ⚡

Thanks for the quick fix @camilamaia

@camilamaia camilamaia merged commit 416249a into master Jun 8, 2021
@camilamaia camilamaia deleted the 389 branch June 8, 2021 14:22
@camilamaia camilamaia mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

Assignees

@camilamaia camilamaia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changelog Lint Workflow failed

3 participants

@camilamaia @codecov-commenter @Pradhvan