Skip to content

Added request name to results variable passed to report (#354)#390

Merged
camilamaia merged 4 commits intoscanapi:masterfrom
hebertjulio:354
Jun 11, 2021
Merged

Added request name to results variable passed to report (#354)#390
camilamaia merged 4 commits intoscanapi:masterfrom
hebertjulio:354

Conversation

@hebertjulio
Copy link
Copy Markdown
Member

@hebertjulio hebertjulio commented Jun 7, 2021 •
edited
Loading

Description

Show request names in the report.

Motivation behind this PR?

Requests for different purposes with the same paths.

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.

Issue

Closes #354

@hebertjulio hebertjulio requested review from a team as code owners June 7, 2021 16:54
camilamaia
camilamaia reviewed Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR, thanks @hebertjulio !! I left some minor suggestions.

Comment thread tests/unit/tree/request_node/test_run.py Outdated
Comment thread scanapi/tree/request_node.py Outdated
Comment thread CHANGELOG.md Outdated
@camilamaia camilamaia requested a review from Pradhvan June 8, 2021 17:21
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Jun 8, 2021

Screenshot to show how cool is the report with the change:

image

Thanks @hebertjulio !

@camilamaia camilamaia self-requested a review June 8, 2021 18:29
camilamaia
camilamaia approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Jun 10, 2021

@Pradhvan can I go ahead and merge the PR? Or do you have any suggestions/comments?

@hebertjulio
Copy link
Copy Markdown
Member Author

hebertjulio commented Jun 10, 2021

I will resolve merge conflicts

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Jun 11, 2021

@hebertjulio left two minor reviews. The rest of the PR looks good to me. Great job 🤗

Pradhvan
Pradhvan requested changes Jun 11, 2021
View reviewed changes
Comment thread scanapi/tree/request_node.py Outdated
Comment thread scanapi/tree/request_node.py Outdated
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Jun 11, 2021 •
edited
Loading

@hebertjulio @Pradhvan I am going to release a new version right now and I would love to have already this new feature on it. Can I add Pradhvan's suggestions and merge it? If we need more changes in the docstrings, we can open a new PR later. Is that ok?

camilamaia
camilamaia reviewed Jun 11, 2021
View reviewed changes
Comment thread scanapi/tree/request_node.py Outdated
camilamaia
camilamaia reviewed Jun 11, 2021
View reviewed changes
Comment thread scanapi/tree/request_node.py Outdated
@camilamaia camilamaia requested a review from Pradhvan June 11, 2021 12:29
camilamaia
camilamaia reviewed Jun 11, 2021
View reviewed changes
Comment thread scanapi/tree/request_node.py Outdated
camilamaia
camilamaia reviewed Jun 11, 2021
View reviewed changes
Comment thread scanapi/tree/request_node.py Outdated
@camilamaia camilamaia merged commit 781593d into scanapi:master Jun 11, 2021
@camilamaia camilamaia mentioned this pull request Jun 11, 2021
Merged
@hebertjulio
Copy link
Copy Markdown
Member Author

hebertjulio commented Jun 11, 2021

Of course @camilamaia , that's fine with me, thanks 😄

@hebertjulio hebertjulio deleted the 354 branch June 11, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

@Pradhvan Pradhvan Awaiting requested review from Pradhvan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add request name to results variable passed to report

3 participants

@hebertjulio @camilamaia @Pradhvan